fix(ui/collectorList-telegraf): sort telegrafs based on buckets #15510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
drdelambre and
hoorayimhelping
and removed request for
a team
|
while you're fixing test snapshots.. try to write a test for this one |
asalem1
commented
Oct 21, 2019
asalem1
commented
Oct 21, 2019
121watts
reviewed
Oct 21, 2019
121watts
approved these changes
Oct 21, 2019
| @@ -6,7 +6,8 @@ | |||
| "lib": ["es2017", "dom"], | |||
| "types": ["cypress", "mocha", "node"], | |||
| "jsx": "react", | |||
| "allowSyntheticDefaultImports": true | |||
| "allowSyntheticDefaultImports": true, | |||
asalem1
force-pushed
the
fix/telegrafs-bucket-sort
branch
from
8bbab27
to
6615b84
Compare
zoesteinkamp
approved these changes
Oct 22, 2019
asalem1
force-pushed
the
fix/telegrafs-bucket-sort
branch
from
07d8df2
to
3400eea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15247
Problem
UI/Telegrafs should be sortable based on bucket name
Solution
Modified the sortKey to accurately reflect the bucket's location in the data, thereby integrating the existing sort functionality.