Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): change task ID runs success status from 200 to 201 #15592

Merged
merged 1 commit into from
Oct 28, 2019
Merged

fix(api): change task ID runs success status from 200 to 201 #15592

merged 1 commit into from
Oct 28, 2019

Conversation

gavincabbage
Copy link
Contributor

@gavincabbage gavincabbage commented Oct 26, 2019 •
edited
Loading

Closes #15177

Changes success status code for task runs endpoint (/api/v2/tasks/:id/runs) from 200 to 201.

Note that the swagger.yml file already documented a 201 status for this endpoint, so this PR rectifies that discrepancy.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@gavincabbage gavincabbage force-pushed the fix/task-id-runs-status-code branch from 11b0524 to 6fb8a67 Compare October 26, 2019 04:17
@gavincabbage gavincabbage requested a review from a team October 28, 2019 13:55
@ghost ghost requested review from AlirieGray and removed request for a team October 28, 2019 13:55
stuartcarnie
stuartcarnie approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have consistency with the Swagger spec 💯

@gavincabbage gavincabbage merged commit c912ee3 into master Oct 28, 2019
@gavincabbage gavincabbage deleted the fix/task-id-runs-status-code branch October 28, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlirieGray AlirieGray AlirieGray approved these changes

@stuartcarnie stuartcarnie stuartcarnie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

POST to /tasks/{taskID}/runs should return a 201
3 participants
@gavincabbage @stuartcarnie @AlirieGray