Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): add filter to fieldOptions when dragging a column #15655

Closed
wants to merge 1 commit into from
Closed

fix(ui): add filter to fieldOptions when dragging a column #15655

wants to merge 1 commit into from

Conversation

TCL735
Copy link
Contributor

@TCL735 TCL735 commented Oct 30, 2019

Closes #15569

Change the filter for unused field options into a private method to allow it to be used for drag events.

@TCL735 TCL735 assigned TCL735 and unassigned TCL735 Oct 30, 2019
@TCL735 TCL735 requested a review from a team October 31, 2019 21:10
@ghost ghost requested review from 121watts and zoesteinkamp and removed request for a team October 31, 2019 21:10
@TCL735 TCL735 requested review from hoorayimhelping and a team October 31, 2019 21:10
@ghost ghost removed their request for review October 31, 2019 21:10
@TCL735 TCL735 force-pushed the fix/15569_table_columns_reorderable branch from 644a917 to 31238ff Compare October 31, 2019 21:51
hoorayimhelping
hoorayimhelping approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@zoesteinkamp
Copy link
Contributor

Looks good!

zoesteinkamp
zoesteinkamp approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@zoesteinkamp zoesteinkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@TCL735 TCL735 changed the title Fix/15569 table columns reorderable fix(ui): add filter to fieldOptions when dragging a column Oct 31, 2019
@TCL735 TCL735 closed this Oct 31, 2019
@TCL735 TCL735 mentioned this pull request Oct 31, 2019
Merged
@TCL735 TCL735 deleted the fix/15569_table_columns_reorderable branch October 31, 2019 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@121watts 121watts 121watts approved these changes

@zoesteinkamp zoesteinkamp zoesteinkamp approved these changes

@hoorayimhelping hoorayimhelping hoorayimhelping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table columns are not re-orderable
4 participants
@TCL735 @zoesteinkamp @hoorayimhelping @121watts