feat(ui): tweak telegraf nginx and redis flows #15710
Conversation
ghost
requested review from
121watts and
drdelambre
and removed request for
a team
hoorayimhelping
force-pushed
the
bs_fix_nginx_wizard_
branch
2 times, most recently
from
fd10013 to
50f99cd
Compare
| AutoComplete, | ||
| Columns, |
ui/cypress/e2e/collectors.test.ts
Outdated
| // fix for https://github.com/influxdata/influxdb/issues/15500 | ||
| describe('configuring nginx', () => { | ||
| beforeEach(() => { | ||
| cy.contains('Create Configuration').click() |
There was a problem hiding this comment.
why this and not just cy.visit(whateverurl)? do we want to test that you always get to the page the same way? or is this some weirdness with the tests? also, idk what i'm reading
There was a problem hiding this comment.
this all happens in the context of a popups / modals - you click 'Create Configuration', then you click NGINX (or redis), then Cotinue, etc. i'll add a comment explaining it.
There was a problem hiding this comment.
might be fine as is. i was just under the impression that all of our modals are currently behind a route and got suspicious about state management within the app.
There was a problem hiding this comment.
@drdelambre depending on the url you are trying to visit since it might be outside of our control. Generally, if we're trying to test out whether or not we are visiting that other page (i.e. within our site) it's just easy to test out that other page separately rather than include that within the scope of this test
| @@ -77,7 +77,7 @@ describe('Onboarding.Components.ConfigureStep.Streaming.ConfigFieldSwitcher', () | |||
| const {wrapper} = setup({fieldName, fieldType, value}, true) | |||
|
|
|||
| const input = wrapper.find(ArrayFormElement) | |||
| const formElement = wrapper.find(FormElement) | |||
| const formElement = wrapper.find(FormElement).first() | |||
hoorayimhelping
force-pushed
the
bs_fix_nginx_wizard_
branch
from
50f99cd to
f5d70db
Compare
|
|
||
| it('can add and delete urls', () => { | ||
| cy.getByTestID('input-field').type('http://localhost:9999') | ||
| cy.contains('Add').click() |
There was a problem hiding this comment.
How would you feel about checking to see if the input-field was cleared after the click resolved?
Closes #15500
This wasn't actually a bug, but a confusing interaction. This uri array component expects users to hit enter to add an item to the list (good luck, mobile / tablet users). This adds a button to help out that interaction. It also changes the way the form is handled so that it doesn't fire an empty event, causing an error.
The bug was reported for nginx, but the confusing interaction also appeared in redis, so this fix has been applied there as well. e2e tests were added to both.