-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storage): array cursor iterator should return stats of all observed cursors #15731
Conversation
I just ran this with our signed integer test and it failed. |
…returns accumulated result
503abae
to
34ee47a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, @GeorgeMac – thanks for uncovering and fixing!
Cheers @stuartcarnie and @benbjohnson 👍 |
…ross all observed cursors
34ee47a
to
6e616b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GeorgeMac. We were lucky to uncover this bug!
Closes #15732
arrayCursorIterator.Stats()
method.arrayCursorIterator.Stats()
to accumulate all the cursor field stats values into a single response.@stuartcarnie showed me that the
builldXArrayCursor
methods actually retain previously read stats and accumlate them on calls toreset
which is how all read stats are accumulated in the end.