Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): adding bundle analyzer for prod and dev #15749

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

drdelambre
Copy link
Contributor

this adds the ability for developers to compare bundle optimizations. when analyzing in develop mode (read: yarn start), assets are uncompressed and can be viewed at http://localhost:9998. When in production mode (read: yarn build), the analysis can be reached by opening build/bundle-report.html.

as a point of order, remember that file size isn't as important from a network resource perspective, and that many small files is fine (production will start running http2 soon to remove much of the overhead of asset handshakes), but that large files slow down the time to first render + interaction by increasing time spent parsing the file (read: its an interpreted language). Best case scenario is to send a small file with only enough code to represent the current view, and to start loading everything else while the user clicks around.

@drdelambre drdelambre requested a review from ebb-tide November 4, 2019 21:26
Copy link
Contributor

@ebb-tide ebb-tide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌵 🌵 🌵

@drdelambre
Copy link
Contributor Author

found out all of monitoring team's assets are served with http2 because we are cool. working with e commerce to help get them cool too.

@drdelambre drdelambre merged commit a04a95d into master Nov 4, 2019
@drdelambre drdelambre deleted the alex_chore_analyzer branch November 4, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants