fix(cmd/influx): fix long startup when running influx help and other similar commands.
#15777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchikwekwe
force-pushed
the
fix/long-startup
branch
3 times, most recently
from
052240e to
f287c30
Compare
nathanielc
suggested changes
Nov 6, 2019
| platform "github.com/influxdata/influxdb" | ||
| _ "github.com/influxdata/influxdb/query/builtin" | ||
|
|
||
| _ "github.com/influxdata/influxdb/query/stdlib" // Import the stdlib | ||
| "github.com/spf13/cobra" | ||
| "github.com/spf13/viper" |
There was a problem hiding this comment.
Can you remove the extra blank lines here and below?
There was a problem hiding this comment.
yeah, no problem.
fchikwekwe
force-pushed
the
fix/long-startup
branch
from
6b0a18e to
bdd6c6e
Compare
nathanielc
approved these changes
Nov 6, 2019
fchikwekwe
force-pushed
the
fix/long-startup
branch
from
9953f87 to
e5e57a7
Compare
cmd/influx/query.go
Outdated
| @@ -4,9 +4,12 @@ import ( | |||
| "context" | |||
| "fmt" | |||
|
|
|||
| "github.com/influxdata/flux" | |||
|
|
|||
There was a problem hiding this comment.
Please remove this blank line. Our convention is to group all non-standard-library imports together.
cmd/influx/repl.go
Outdated
| @@ -41,6 +42,8 @@ func init() { | |||
| } | |||
|
|
|||
| func replF(cmd *cobra.Command, args []string) error { | |||
| flux.FinalizeBuiltIns() | |||
There was a problem hiding this comment.
This should move after the flag validation and before the call to getFluxREPL -- it would be frustrating to spend the multiple-second wait only to find out that you mistyped an org ID.
There was a problem hiding this comment.
Yeah that is true. Changing it now.
cmd/influx/query.go
Outdated
| @@ -40,6 +43,8 @@ func init() { | |||
| } | |||
|
|
|||
| func fluxQueryF(cmd *cobra.Command, args []string) error { | |||
| flux.FinalizeBuiltIns() | |||
There was a problem hiding this comment.
This call should also move after flag validation and before getFluxREPL.
…x help' or related commands
fchikwekwe
force-pushed
the
fix/long-startup
branch
from
dd0a4f1 to
0664dbc
Compare
mark-rushakoff
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15441
Describe your proposed changes here.