Zs filtering telegraph input #15601 #15787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
desa and
hoorayimhelping
and removed request for
a team
drdelambre
reviewed
Nov 6, 2019
| cy.get('@org').then(({id}: Organization) => { | ||
| cy.createTelegraf('newteleg', description, id, 'zoebucket') | ||
| }) | ||
| cy.reload() |
There was a problem hiding this comment.
can you add one of those cy.get({timeout}) lines here after the reload to ensure that the page has loaded?
hoorayimhelping
suggested changes
Nov 6, 2019
There was a problem hiding this comment.
I was having trouble getting this working locally with a bucket name of System Metrics and labels label 1 and label 2. I poked around and searched for searchKeys and saw some other calls to labels[].name in the codebase, so I changed that locally and my example started working.
I bet your bucket name and label name share a lot of the same letters?
hoorayimhelping
approved these changes
Nov 8, 2019
need to just fix tests now
Cleaning up test
Adding additions
zoesteinkamp
force-pushed
the
zs-filteringTelegraphInput-#15601
branch
from
b9a1986
to
5548f9a
Compare
Removing only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15601
Describe your proposed changes here.