Spread #1591
Merged
Spread #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| result.Rows[0] = row |
There was a problem hiding this comment.
This change was due to go vet failing. There is an unfortunate side affect of typed slices outside of the package that it doesn't understand, and will likely not change this behavior.
|
If the goal is to have each mapper send its local max and mix, and then the reducer emit the difference between the largest of all maxes and the smallest of all mins, then +1. I have one 1 minor comment. |
| result.max = math.Max(result.max, val.max) | ||
| result.min = math.Min(result.min, val.min) | ||
| } | ||
| spread := result.max - result.min |
There was a problem hiding this comment.
Not much point calculating spread if pointsYielded is false after the for loop.
| @@ -753,6 +755,52 @@ func ReduceMax(key Key, values []interface{}, e *Emitter) { | |||
| } | |||
| } | |||
|
|
|||
| type spreadMapOutput struct { | |||
| min, max float64 | |||
There was a problem hiding this comment.
These should be exported so that they can be serialized later
|
I know you just merged, but I had one comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1476