feat(ui): Add matching rules card to alert builder #16014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebb-tide
force-pushed
the
feat-add-matching-NR-UI
branch
from
9ea16e7
to
468de69
Compare
ebb-tide
force-pushed
the
feat-add-matching-NR-UI
branch
from
468de69
to
f91d71d
Compare
ghost
requested review from
asalem1 and
hoorayimhelping
and removed request for
a team
asalem1
reviewed
Dec 31, 2019
|
|
||
| // API | ||
| import * as api from 'src/client' | ||
| import {getNotificationRules} from 'src/client' |
There was a problem hiding this comment.
Did we establish that we'd follow an aliased convention of apiGetNotificationRules?
There was a problem hiding this comment.
thanks for reminder! :)
asalem1
reviewed
Dec 31, 2019
asalem1
approved these changes
Dec 31, 2019
ebb-tide
force-pushed
the
feat-add-matching-NR-UI
branch
from
468a642
to
824b0be
Compare
ebb-tide
force-pushed
the
feat-add-matching-NR-UI
branch
from
824b0be
to
93a0fc4
Compare
alexpaxton
pushed a commit
that referenced
this pull request
Jan 9, 2020
* feat(ui): Add matching rules card to alert builder * feat(checks): Add tags from query results to NR matching query parameters * feat(ui): Update changelog * feat(nr): Change api function to match import convention * fix(ui): Fix changelog update mistake * Click submit button after typing in time machine * feat(notification rules): Add feature flag to matching notification rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15806
Adds 'matching rules' card to check creation page, which displays any notification rules that "would match" the tags that are on statuses generated by the check. The back end work is in #16328.