feat(cmd): bucket create to accept org name as flag #16187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dearyhud
force-pushed
the
15828/bucket-create
branch
from
025fc49 to
c28b945
Compare
kelwang
approved these changes
Dec 10, 2019
dearyhud
force-pushed
the
15828/bucket-create
branch
from
c28b945 to
7e92c19
Compare
imogenkinsman
approved these changes
Dec 10, 2019
dearyhud
force-pushed
the
15828/bucket-create
branch
from
7e92c19 to
cf47291
Compare
|
can we add the tests in this body of work? a promise to come back and add tests in later, almost never comes to fruition. Be good to start delivering on our testing for cli stuff |
adds: - `--org` or -`o` shorthand for the organization name enables the user to specify an organization name when creating a bucket.
dearyhud
force-pushed
the
15828/bucket-create
branch
from
cf47291 to
0e4f056
Compare
- to ensure consistency across the cli the shorthand is being given to the shorthand was used for both flags inconsistently, but now it only works for
dearyhud
force-pushed
the
15828/bucket-create
branch
from
0e4f056 to
afa03e7
Compare
dearyhud
commented
Dec 10, 2019
cmd/influx/inspect.go
Outdated
| @@ -63,6 +63,7 @@ in the following ways: | |||
| inspectReportTSMCommand.Flags().BoolVarP(&inspectReportTSMFlags.detailed, "detailed", "", false, "emit series cardinality segmented by measurements, tag keys and fields. Warning, may take a while.") | |||
|
|
|||
| inspectReportTSMCommand.Flags().StringVarP(&inspectReportTSMFlags.orgID, "org-id", "", "", "process only data belonging to organization ID.") | |||
| inspectReportTSMCommand.Flags().StringVarP(&inspectReportTSMFlags.orgID, "org", "o", "", "process only data belonging to organization ID.") | |||
There was a problem hiding this comment.
just caught this. will patch this up
imogenkinsman
approved these changes
Dec 10, 2019
dearyhud
force-pushed
the
15828/bucket-create
branch
from
bc158d5 to
09697c3
Compare
imogenkinsman
approved these changes
Dec 10, 2019
jsteenb2
reviewed
Dec 10, 2019
| if err != nil { | ||
| return fmt.Errorf("invalid org ID provided: %s", err.Error()) | ||
| if b.orgID != "" { | ||
| var err error |
There was a problem hiding this comment.
this isn't going to work, breaks the pattern for the builder...
There was a problem hiding this comment.
any SVC dep needs to be provided through DI not dumped in here globally
needs fixup
There was a problem hiding this comment.
Thanks for catching, we'll fix in the morning.
4 tasks
alexpaxton
pushed a commit
that referenced
this pull request
Jan 9, 2020
* enables the user to specify an organization name when creating a bucket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enables a user to specify an organization name when creating a bucket from the influx cli.
Closes #15828
The influx bucket create command doesn't seem to have a -o flag for specifying the organization name. This PR adds a flag
--orgor-ofor specifying the org name to avoid the overhead of having to lookup an organization id