fix: add a timestamp to the telegraf label creation to insure uniqueness #16204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoorayimhelping
force-pushed
the
bs_fix_telegraf_creation
branch
from
c369113
to
b8f58d4
Compare
asalem1
suggested changes
Dec 11, 2019
hoorayimhelping
force-pushed
the
bs_fix_telegraf_creation
branch
from
b8f58d4
to
93f696c
Compare
asalem1
approved these changes
Dec 11, 2019
121watts
approved these changes
Dec 11, 2019
ui/cypress/e2e/collectors.test.ts
Outdated
| @@ -356,6 +356,30 @@ describe('Collectors', () => { | |||
| }) | |||
| }) | |||
| }) | |||
|
|
|||
| // fix for https://github.com/influxdata/influxdb/issues/15730 | |||
| it('creates a cofiguration with a unique label', () => { | |||
There was a problem hiding this comment.
Suggested change
| it('creates a cofiguration with a unique label', () => { | |
| it('creates a configuration with a unique label', () => { |
| @@ -454,7 +454,7 @@ const createTelegraf = async (dispatch, getState, plugins) => { | |||
|
|
|||
| const createdLabel = await client.labels.create({ | |||
| orgID: org.id, | |||
| name: '@influxdata.token', | |||
| name: `@influxdata.token-${new Date().getTime()}`, | |||
There was a problem hiding this comment.
perhaps the same comment in the cypress test here?
hoorayimhelping
force-pushed
the
bs_fix_telegraf_creation
branch
from
93f696c
to
a4f4ed6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15730
Labels require unique names. The buggy behavior when we create a telegraf config is to create a label for the config and to name every label
@influxdata.name. This fix appends a timestamp to@influxdata.name(that string is being filtered on, so we want keep@influxdata.name)