Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pkger): add export functionality to notification endpoints #16234

Merged
merged 2 commits into from
Dec 17, 2019

Conversation

jsteenb2
Copy link
Contributor

@jsteenb2 jsteenb2 commented Dec 16, 2019

also provides secret refs to be supported

Sorry, something went wrong.

@jsteenb2 jsteenb2 requested review from a team as code owners December 16, 2019 22:23
@jsteenb2 jsteenb2 removed request for a team December 16, 2019 22:23
@jsteenb2 jsteenb2 force-pushed the 4968p/pkger_endpoints_secret_ref branch 6 times, most recently from 9118b61 to a50dbc5 Compare December 17, 2019 18:32
@jsteenb2 jsteenb2 force-pushed the 4968p/pkger_endpoints_secret_ref branch from a50dbc5 to 0e6c434 Compare December 17, 2019 18:50
@jsteenb2 jsteenb2 force-pushed the 4968p/pkger_endpoints_secret_ref branch from 0e6c434 to 2581825 Compare December 17, 2019 19:13
@jsteenb2
Copy link
Contributor Author

tests failing on the data race for writing to zap logger, should probably wrap that thing with a mutex or something to eliminate the flaky tests from reappearing.... seeing it a lot

@jsteenb2 jsteenb2 requested a review from a team December 17, 2019 19:14
@jsteenb2 jsteenb2 merged commit d42bbb3 into master Dec 17, 2019
@jsteenb2 jsteenb2 deleted the 4968p/pkger_endpoints_secret_ref branch December 17, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants