fix(kv): Store canceled task runs in the correct bucket #16238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettbuddin
force-pushed
the
bb-cancelation-bucket
branch
2 times, most recently
from
5d33e60 to
affb0fb
Compare
Task runs are stored and retrieved from the `taskRunsv1` bucket, but when they are canceled they are incorrectly placed in the `tasksv1` bucket. Once this has been done, further look ups of the task run fail, because it is located in the wrong bucket. This addresses the problem by placing them back into the `taskRunsv1` bucket. An additional test has been added to ensure we are able to successfully read a canceled run.
brettbuddin
force-pushed
the
bb-cancelation-bucket
branch
from
affb0fb to
a2de2cc
Compare
ghost
requested review from
brettbuddin
force-pushed
the
bb-cancelation-bucket
branch
from
994fc04 to
6de0194
Compare
stuartcarnie
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task runs are stored and retrieved from the
taskRunsv1bucket, but when they are canceled they are incorrectly placed in thetasksv1bucket. Once this has been done, further look ups of the task run fail, because it is located in the wrong bucket.This addresses the problem by placing them back into the
taskRunsv1bucket. An additional test has been added to ensure we are able to successfully read a canceled run.