fix(kv): Prevent infinite loop condition when listing tasks by org. #16249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goller
approved these changes
Dec 17, 2019
brettbuddin
force-pushed
the
bb-infinite-loop
branch
from
147c93a
to
c898d85
Compare
e-dard
approved these changes
Dec 18, 2019
In the event that findTaskByIDWithAuth cannot find the task ID contained in the bucket, the outer loop will never terminate. This ensures that we are calling Next() along-side any calls to continue while using a Cursor.
brettbuddin
force-pushed
the
bb-infinite-loop
branch
from
c898d85
to
01b683c
Compare
|
@brettbuddin 💯 for looking for ways to improve the loop ergonomics and your pragmatism for the urgency. We could follow this up later with an improvement like this: https://play.golang.org/p/dygkrQYG2fu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes influxdata/idpe#5592
In the event that
findTaskByIDWithAuthcannot find the task ID contained in the bucket, the outer loop will never terminate.This ensures that we are calling
Next()along-side any calls tocontinuewhile using aCursor.Notes:
I investigated improving the overall ergonomics of these cursor-based loops by hoisting the cursor advancement to the top of the iterations—instead of being at the tail-end of them. However, due to seeking behavior, the pre-conditions of the loop become a bit trickier. Perhaps this is an area of further improvement. Generally, loops that have cross-iteration state interaction tend to cause surprising behavior like this when
continuegets involved.