Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pkger): add support for check resource to pkger parser #16259

Merged
merged 2 commits into from
Dec 18, 2019
Merged

feat(pkger): add support for check resource to pkger parser #16259

merged 2 commits into from
Dec 18, 2019

Conversation

jsteenb2
Copy link
Contributor

@jsteenb2 jsteenb2 commented Dec 18, 2019 •
edited
Loading

add preliminary support for checks to parser

@jsteenb2 jsteenb2 requested review from a team as code owners December 18, 2019 01:59
@jsteenb2 jsteenb2 requested review from a team and removed request for a team December 18, 2019 01:59
@jsteenb2 jsteenb2 force-pushed the 4966p/pkger_check_resource branch 4 times, most recently from 6e1efaa to 3c17c21 Compare December 18, 2019 04:03
@jsteenb2
chore: refactor bits of checks and its dependencies for readability
65b9313
@jsteenb2
feat(pkger): add support for check resource to pgker parser
333a6ea 
adds both basic resource specific and the label association
support to check resource in parser
@jsteenb2 jsteenb2 force-pushed the 4966p/pkger_check_resource branch from 3c17c21 to 333a6ea Compare December 18, 2019 05:56
@jsteenb2 jsteenb2 merged commit 7c10270 into master Dec 18, 2019
@jsteenb2 jsteenb2 deleted the 4966p/pkger_check_resource branch December 18, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dearyhud dearyhud dearyhud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsteenb2 @dearyhud