feat(pkger): add application functionality for the notification rules #16305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jsteenb2
commented
Dec 20, 2019
•
jsteenb2
commented
- CHANGELOG.md updated with a link to the PR (not the Issue)
- Well-formatted commit messages
- Rebased/mergeable
- Tests pass
- http/swagger.yml updated (if modified Go structs or API)
jsteenb2
force-pushed
the
4965p/pkger_parser_notif_rules
branch
from
ed78778 to
256b3c9
Compare
jsteenb2
force-pushed
the
4965p/pkger_parser_notif_rules
branch
from
256b3c9 to
51ac6d1
Compare
jsteenb2
force-pushed
the
4965p/pkger_parser_notif_rules
branch
from
51ac6d1 to
4318cbd
Compare
dearyhud
approved these changes
Dec 20, 2019
| @@ -1032,6 +1043,18 @@ func (s *Service) Apply(ctx context.Context, orgID, userID influxdb.ID, pkg *Pkg | |||
| } | |||
| } | |||
|
|
|||
| // this is required after first primary run and before secondary run, b/c this has dependencies | |||
There was a problem hiding this comment.
Nit, but feels like this comment could be simplified / made more easy to understand.
Something like
"This has to be run after the above primary resources, because it relies on notification endpoints already being applied."
There was a problem hiding this comment.
excellent point! thank you for improving that, struggled to figure out what to write, your version is miles ahead of where mine was lol
imogenkinsman
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.