feat(pkger): add export support for notification rules #16312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jsteenb2
commented
Dec 20, 2019
•
jsteenb2
commented
- CHANGELOG.md updated with a link to the PR (not the Issue)
- Well-formatted commit messages
- Rebased/mergeable
- Tests pass
- http/swagger.yml updated (if modified Go structs or API)
jsteenb2
force-pushed
the
4965p/pkger_noti_rules_export
branch
from
279b4e6
to
4ea751b
Compare
jsteenb2
force-pushed
the
4965p/pkger_noti_rules_export
branch
2 times, most recently
from
c5c0b3c
to
01a1c68
Compare
imogenkinsman
approved these changes
Dec 21, 2019
jsteenb2
force-pushed
the
4965p/pkger_noti_rules_export
branch
from
01a1c68
to
6933c12
Compare
jsteenb2
force-pushed
the
4965p/pkger_noti_rules_export
branch
from
6933c12
to
7639c75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.