Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pkger): add dry run functionality for task resource #16322

Merged
merged 1 commit into from
Dec 23, 2019
Merged

feat(pkger): add dry run functionality for task resource #16322

merged 1 commit into from
Dec 23, 2019

Conversation

jsteenb2
Copy link
Contributor

@jsteenb2 jsteenb2 commented Dec 23, 2019 •
edited
Loading

adds dry run functionality for tasks

@jsteenb2 jsteenb2 requested a review from a team December 23, 2019 19:03
@jsteenb2 jsteenb2 requested review from a team as code owners December 23, 2019 19:07
@jsteenb2 jsteenb2 removed request for a team December 23, 2019 19:07
@kelwang kelwang requested a review from a team December 23, 2019 19:09
@ghost ghost requested review from GeorgeMac and removed request for a team December 23, 2019 19:09
@jsteenb2 jsteenb2 removed the request for review from GeorgeMac December 23, 2019 19:10
kelwang
kelwang reviewed Dec 23, 2019
View reviewed changes
Copy link
Contributor

@kelwang kelwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would like to have a review from the compute team

@jsteenb2
Copy link
Contributor Author

@kelwang curious why that is?

@jsteenb2 jsteenb2 merged commit 8e87498 into master Dec 23, 2019
@jsteenb2 jsteenb2 deleted the 4964p/pkger_add_taks branch December 23, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelwang kelwang kelwang left review comments

@dearyhud dearyhud dearyhud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsteenb2 @dearyhud @kelwang