feat(storage): restore tool #16352
feat(storage): restore tool #16352
Conversation
tmgordeeva
force-pushed
the
jgm-restore
branch
3 times, most recently
from
8606b7a to
55eb211
Compare
Adds a restore tool which does offline restore of data and metadata.
tmgordeeva
force-pushed
the
jgm-restore
branch
from
55eb211 to
fd869ef
Compare
cmd/influxd/restore/command.go
Outdated
|
|
||
| func restoreEngine() error { | ||
| dataDir := filepath.Join(flags.enginePath, "/data") | ||
| if err := os.Mkdir(dataDir, 0777); err != nil { |
There was a problem hiding this comment.
Should this be os.MkdirAll(dataDir, 0777) in case we need to define parents?
cmd/influxd/restore/command.go
Outdated
| return err | ||
| } | ||
|
|
||
| return os.Mkdir(flags.enginePath, 0777) |
There was a problem hiding this comment.
I think this should be os.MkdirAll(flags.enginePath, 0777) to ensure the parents are made too. Since we check to see if /var/lib/path/to/data/engine exists in L145, we should make sure that this is fully created. Alternatively if we're just changing the perms we should use Chmod?
There was a problem hiding this comment.
I would rather not worry about chmod'ing an existing dir here. I agree that MkdirAll makes sense.
cmd/influxd/restore/command.go
Outdated
| return err | ||
| } | ||
|
|
||
| return os.Mkdir(flags.enginePath, 0777) |
There was a problem hiding this comment.
I would rather not worry about chmod'ing an existing dir here. I agree that MkdirAll makes sense.
cmd/influxd/restore/command.go
Outdated
|
|
||
| func restoreBolt() error { | ||
| backupBolt := filepath.Join(flags.backupPath, bolt.DefaultFilename) | ||
| f, err := os.OpenFile(backupBolt, os.O_RDONLY, 0666) |
| } | ||
| defer f.Close() | ||
|
|
||
| w, err := os.OpenFile(flags.boltPath, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0666) |
There was a problem hiding this comment.
(do not use os.Open here, as the file is opened for writing)
| count := 0 | ||
| err := filepath.Walk(flags.backupPath, func(path string, info os.FileInfo, err error) error { | ||
| if strings.Contains(path, ".tsm") { | ||
| f, err := os.OpenFile(path, os.O_RDONLY, 0600) |
|
Tested by creating a backup, restoring and verifying:
|
cmd/influxd/restore/command.go
Outdated
| return err | ||
| } | ||
|
|
||
| return os.Mkdir(flags.enginePath, 0777) |
There was a problem hiding this comment.
This one still should be changed to MkdirAll
|
Replaced by #16504 |
Adds an offline restore tool to replace existing data and metadata with a backup.
Closes #15605
Closes #15606