test: fix flaky explorer tests #16392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoorayimhelping
force-pushed
the
bs_e2e_work
branch
4 times, most recently
from
3a9ade4
to
90cbfd2
Compare
hoorayimhelping
commented
Jan 3, 2020
hoorayimhelping
commented
Jan 3, 2020
| @@ -12,7 +12,8 @@ describe('Onboarding.Components.DataListening', () => { | |||
| describe('if button is clicked', () => { | |||
| it('displays connection information', () => { | |||
| const {getByTitle, getByText} = renderWithRedux( | |||
| <DataListening bucket="bucket" />) | |||
| <DataListening bucket="bucket" /> | |||
There was a problem hiding this comment.
prettier /shrug
121watts
approved these changes
Jan 3, 2020
hoorayimhelping
force-pushed
the
bs_e2e_work
branch
from
90cbfd2
to
463c51c
Compare
|
@121watts been rerunning the tests in circle with no issue, can you show me how you make a loop? where do you put the loop? |
121watts
reviewed
Jan 3, 2020
| @@ -359,16 +358,16 @@ describe('DataExplorer', () => { | |||
| cy.getByTestID('time-machine-submit-button').should('be.disabled') | |||
|
|
|||
| cy.getByTestID('flux-editor').within(() => { | |||
| cy.get('textarea').type('yo', {force: true}) | |||
| cy.get('.CodeMirror').type('yo') | |||
| cy.getByTestID('time-machine-submit-button').should('not.be.disabled') | |||
| }) | |||
| }) | |||
|
|
|||
| it('disables submit when a query is deleted', () => { | |||
There was a problem hiding this comment.
Suggested change
| it('disables submit when a query is deleted', () => { | |
| for (let i = 0; i < 50; i++) { | |
| it('disables submit when a query is deleted', () => { |
There was a problem hiding this comment.
@hoorayimhelping here's an example of how to loop one test.
There was a problem hiding this comment.
sweet, thanks
hoorayimhelping
force-pushed
the
bs_e2e_work
branch
from
223af9a
to
463c51c
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16330
CodeMirror wraps the code textarea so it can apply eye candy to the text. Our tests were targeting the wrapped textarea and using the
force: trueflag to force cypress to type into it. This change instead targets the CodeMirror div that wraps the text area and doesn't force the typing. This seems to work as cypress waits for the text area to be typeable, which CodeMirror seems to handle.