Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): removed buildActiveQuery func to prevent queries from being reset when timeranges are selected. #16404

Merged
merged 3 commits into from
Jan 6, 2020
Merged

fix(ui): removed buildActiveQuery func to prevent queries from being reset when timeranges are selected. #16404

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
939b0cd
fix(ui): removed buildActiveQuery func to prevent queries from being …
asalem1 Jan 3, 2020
277bb4e
fix(ui): readded test skipping in favor of Bucky's changes
asalem1 Jan 6, 2020
5e033b4
fix(ui): removed skip from test again and added changes to changelog
asalem1 Jan 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/cypress/e2e/explorer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ describe('DataExplorer', () => {
})
})

describe('raw script editing', () => {
describe.skip('raw script editing', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
describe.skip('raw script editing', () => {
describe('raw script editing', () => {

beforeEach(() => {
cy.getByTestID('switch-to-script-editor').click()
})
Expand Down
2 changes: 0 additions & 2 deletions ui/src/timeMachine/reducers/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,8 +752,6 @@ export const timeMachineReducer = (

draftState.queryBuilder.tags[index].values = values
draftState.queryBuilder.tags[index].valuesStatus = RemoteDataState.Done

buildActiveQuery(draftState)
})
}

Expand Down