feat(pkger): add jsonnet support for package files #16511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
force-pushed
the
pkger/jsonnet_support
branch
2 times, most recently
from
4fe5c4d to
8322ef5
Compare
jsteenb2
force-pushed
the
pkger/jsonnet_support
branch
from
8322ef5 to
7ef35b9
Compare
kelwang
reviewed
Jan 13, 2020
| @@ -138,8 +148,14 @@ func parseSource(r io.Reader, opts ...ValidateOptFn) (*Pkg, error) { | |||
| switch { | |||
| case strings.Contains(contentType, "json"): | |||
| return parseJSON(bytes.NewReader(b), opts...) | |||
| default: | |||
| case strings.Contains(contentType, "jsonnet"): | |||
There was a problem hiding this comment.
strings.Contains(contentType, "json") will always be true, even if the "content-type" is "jsonnet"
There was a problem hiding this comment.
ohhhh great catch 🥇, will fix that up 👍
There was a problem hiding this comment.
@kelwang push fixed
kelwang
suggested changes
Jan 13, 2020
jsteenb2
force-pushed
the
pkger/jsonnet_support
branch
from
7ef35b9 to
913ee31
Compare
kelwang
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearing up some idea debt. Adds jsonnet support for influx packages.