Broker recovery #1667
Merged
Broker recovery #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the broker recovery so that it determines the last index from the various topic logs instead of persisting the snapshot on every message that comes in.
| @@ -57,6 +57,14 @@ func (b *Broker) metaPath() string { | |||
| return filepath.Join(b.path, "meta") | |||
| } | |||
|
|
|||
| // Index returns the highest index seen by the broker. | |||
There was a problem hiding this comment.
Minor: "seen" is a vague term. Could it be improved?
There was a problem hiding this comment.
I guess somewhere we need to capture that the significance of this is that highest across all topics has been safely applied in the Raft log, if I remember correctly.
|
Some suggested changes, but this code makes sense to me. I would like to see the test tweaked. +1 |
| @@ -774,6 +791,33 @@ func (t *topic) Close() error { | |||
| return nil | |||
| } | |||
|
|
|||
| // loadIndex reads the highest available index for a topic from disk. | |||
| func (t *topic) loadIndex() error { | |||
There was a problem hiding this comment.
This seems like it's going to take a long time if there are quite a bit of topic logs backed up.
There was a problem hiding this comment.
When we add truncation (and log segments) then it'll only have to traverse through the latest log segment for each topic.
|
LGTM, |
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
This reverts commit 70a430c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request fixes the broker recovery so that it determines the last index from the various topic logs instead of persisting the snapshot on every message that comes in.