Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fixed false success message that stemmed from error-swallowing throughout post process #16825

Merged
merged 3 commits into from
Feb 11, 2020
+4 −1
Merged

fix(ui): fixed false success message that stemmed from error-swallowing throughout post process #16825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cd5f79
fix(ui): fixed false success message that stemmed from error-swolling…
asalem1 Feb 11, 2020
d6c81b8
chore(ui): updated changelog with changes
asalem1 Feb 11, 2020
1b47c25
Merge branch 'master' into save-as-error
asalem1 Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

1. [16733](https://github.com/influxdata/influxdb/pull/16733): Fix notification rule renaming panics from UI
1. [16769](https://github.com/influxdata/influxdb/pull/16769): Fix the tooltip for stacked line graphs
1. [16825](https://github.com/influxdata/influxdb/pull/16825): Fixed false success notification for read-only users creating dashboards
1. [16822](https://github.com/influxdata/influxdb/pull/16822): Fix issue with pkger/http stack crashing on dupe content type

## v2.0.0-beta.2 [2020-01-24]
Expand Down
3 changes: 2 additions & 1 deletion ui/src/cells/actions/thunks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,9 @@ export const createCellWithView = (

dispatch(setView(cellID, RemoteDataState.Done, normView))
dispatch(setCell(cellID, RemoteDataState.Done, normCell))
} catch {
} catch (err) {
notify(copy.cellAddFailed())
throw err
}
}

Expand Down
1 change: 1 addition & 0 deletions ui/src/dataExplorer/components/SaveAsCellForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ class SaveAsCellForm extends PureComponent<Props, State> {
onCreateCellWithView(resp.data.id, view)
} catch (error) {
console.error(error)
throw error
}
}

Expand Down