fix(kv): push down org ID to skip in delete URM #16841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are trying to skip deletes that would remove keys that have already been deleted. This is a rather extreme approach and I believe we should think about how to fix user-resource-mappings. Co-authored-by: Lyon Hill <lyondhill@gmail.com> Signed-off-by: Chris Goller <goller@gmail.com>
lyondhill
approved these changes
Feb 12, 2020
GeorgeMac
added a commit
that referenced
this pull request
Feb 13, 2020
This reverts commit a5f508d.
GeorgeMac
added a commit
that referenced
this pull request
Feb 13, 2020
* Revert "fix(kv): Don't stop when key not found from index." This reverts commit bd9167d. * Revert "fix(kv): push down org ID to skip in delete URM (#16841)" This reverts commit a5f508d. * Revert "fix(kv): delete authorization from correct index bucket (#16835)" This reverts commit 7349216. * Revert "feat(kv): Index Authorizations by User ID (#16818)" This reverts commit df36fe9. * Revert "feat: add indexes to urm for user lookups (#16789)" This reverts commit 9561d0a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to skip deletes that would remove keys
that have already been deleted. This is a rather
extreme approach and I believe we should think about how
to fix user-resource-mappings.
It is possible that a cursor does not respect transactions and thus a range may contain already
deleted keys. This is a workaround.