New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): Add lsp wasm and connect to monaco #16842

Merged

ebb-tide merged 18 commits into master from deniz-add-lsp-wasm

Feb 14, 2020

Contributor

ebb-tide commented Feb 12, 2020

Closes #16794

ebb-tide requested review from drdelambre and 121watts

February 12, 2020 20:27

drdelambre reviewed

View reviewed changes

ui/src/external/monaco.fluxCompletions.ts Show resolved Hide resolved

drdelambre reviewed

View reviewed changes

ui/src/external/monaco.fluxCompletions.ts Show resolved Hide resolved

drdelambre reviewed

View reviewed changes

ui/src/shared/components/FluxMonacoEditor.tsx Show resolved Hide resolved

drdelambre reviewed

View reviewed changes

ui/src/shared/components/FluxMonacoEditor.tsx Show resolved Hide resolved

drdelambre reviewed

View reviewed changes

ui/webpack.common.ts Show resolved Hide resolved

drdelambre reviewed

View reviewed changes

ui/webpack.common.ts Show resolved Hide resolved

drdelambre reviewed

View reviewed changes

ui/webpack.common.ts Outdated Show resolved Hide resolved

121watts approved these changes

View reviewed changes

Contributor

121watts left a comment

Can I get a GIF plz?!?!?

ui/src/external/monaco.fluxLang.ts Outdated Show resolved Hide resolved

ui/src/external/monaco.fluxSyntax.ts Show resolved Hide resolved

ui/src/shared/components/FluxMonacoEditor.tsx Show resolved Hide resolved

drdelambre reviewed

View reviewed changes

Contributor

drdelambre left a comment

got some questions around the webpack and supported languages aspects of this

ebb-tide force-pushed the deniz-add-lsp-wasm branch 4 times, most recently from ac0447d to b555bd9 Compare

February 14, 2020 00:33

ebb-tide added 15 commits

February 14, 2020 09:19


          feat(lsp): Add flux-lsp-browswer dependency

d245cf9


          feat(lsp): Change webpack settings to compile lsp wasm

d79457b


          feat(lsp): Add monaco lsp client dep

1dd8725


          feat:lsp instantiate lsp server in monaco editor file

e599077


          feat(lsp): Update monaco loaders and load in webpack.common

6a5daec


          feat(lsp): Update flux-lsp-browser dependency

4d230de


          feat(lsp): Connect monaco to lsp server

fd8ef60


          feat(lsp): Add trigger characters

ba5831e


          feat(lsp): Dispose of completion item provider

f6db85a


          feat(lsp): Remove javascript and go as monaco languages

f8c9e10


          feat(lsp): Fix type errors in tests


          feat(lsp): Define constants file for fluxlangid

6ddbf09


          feat(lsp): Remove console

0120dce


          feat(lsp): Fix variable and function insertion

d51de4e


          feat(lsp): Fix script entering in DE

e487522

ebb-tide added 3 commits

February 14, 2020 09:19


          feat(lsp): FIx task tests

8b8e3ca


          feat(lsp): Add monaco as global

1ca2096


          feat(lsp): Add monaco to window type

eb1dc45

ebb-tide force-pushed the deniz-add-lsp-wasm branch from b555bd9 to eb1dc45 Compare

February 14, 2020 17:19

ebb-tide merged commit 38e014e into master

jacobmarble deleted the deniz-add-lsp-wasm branch

January 2, 2024 22:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet