Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): added labels to buckets #16855

Merged
merged 16 commits into from
Feb 13, 2020
+216 −57
Merged

feat(ui): added labels to buckets #16855

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0f659d1
chore(ui): moved logic into thunk reducer
asalem1 Feb 11, 2020
3aa182c
merged
asalem1 Feb 12, 2020
5f6b9c9
Merge branch 'master' of github.com:influxdata/influxdb
asalem1 Feb 12, 2020
da58370
feat(ui): added labels to buckets
asalem1 Feb 13, 2020
7acd2b7
fix(ui): addressed linter errors
asalem1 Feb 13, 2020
2f204cd
Merge branch 'master' of github.com:influxdata/influxdb
asalem1 Feb 13, 2020
73ab3d4
feat(ui): added labels to buckets
asalem1 Feb 13, 2020
1715d93
fix(ui): addressed linter errors
asalem1 Feb 13, 2020
0d7c60b
chore(ui): updated changelog to reflect changes
asalem1 Feb 13, 2020
94a192c
Merge branch 'bucket-labels' of github.com:influxdata/influxdb into b…
asalem1 Feb 13, 2020
b249de6
fix(ui): fixed broken e2e test
asalem1 Feb 13, 2020
811027a
fix(ui): fixed e2e test
asalem1 Feb 13, 2020
3d82f0d
fix(ui): updated e2e test
asalem1 Feb 13, 2020
a7b5ff3
fix(ui): updated breaking test
asalem1 Feb 13, 2020
a15a53f
feat(ui): made requested PR changes
asalem1 Feb 13, 2020
92081b8
fix(ui): 'you made the perfect test' --alex boatwright
asalem1 Feb 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(ui): fixed e2e test
@asalem1
asalem1 committed Feb 13, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 811027aa59fae5d02ef92ff0f33d81c1c0c24d8e
2 changes: 1 addition & 1 deletion ui/cypress/e2e/buckets.test.ts
View file
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@ describe('Buckets', () => {
cy.getByTestID(`bucket--card--name ${newBucket}`).should('exist')

// Add a label
cy.getByTestID(`bucket--card--name ${newBucket}`).within(() => {
cy.getByTestID(`bucket-card ${newBucket}`).within(() => {
cy.getByTestID('inline-labels--add').click()
})