Simple change so "SHOW TAG VALUES" is as expected #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes basic case for #1688 |
otoolep
force-pushed
the
show_tag_values
branch
from
9523026
to
315b24c
Compare
|
Review again, updated as per spec. |
otoolep
force-pushed
the
show_tag_values
branch
2 times, most recently
from
fac092c
to
fcb982a
Compare
|
This passes locally, trying to see what is up with Travis. |
This change tightens up the type used for "Series" so the pre-existing sort method can be used.
otoolep
force-pushed
the
show_tag_values
branch
from
fcb982a
to
86b91ea
Compare
|
Finally, green build after I fixed up the types. No more 'go vet' issues. |
pauldix
added a commit
that referenced
this pull request
Feb 24, 2015
Simple change so "SHOW TAG VALUES" is as expected
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
…oup()` (#1689) update other modules that used old syntax as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only covers the case where a values for a single tag key is
requested, since there is a question whether anything else should be
supported.