Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pkger): fix bug where tasks are exported for notification rules #17039

Merged
merged 1 commit into from
Feb 27, 2020
Merged

fix(pkger): fix bug where tasks are exported for notification rules #17039

merged 1 commit into from
Feb 27, 2020

Conversation

jsteenb2
Copy link
Contributor

@jsteenb2 jsteenb2 commented Feb 27, 2020 •
edited
Loading

references #17038

first piece of fixing this bug. Still exploring if there are more issues with the root tasks themselves.

@jsteenb2 jsteenb2 requested a review from a team February 27, 2020 23:04
imogenkinsman
imogenkinsman approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@imogenkinsman imogenkinsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:! Great to see this come with a test.

@jsteenb2 jsteenb2 merged commit 1a12ebc into master Feb 27, 2020
@jsteenb2 jsteenb2 deleted the 17038/pkger_export_check_tasks_bug branch February 27, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imogenkinsman imogenkinsman imogenkinsman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsteenb2 @imogenkinsman