fix(pkger): correct the export of tasks to include system type tasks #17042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
force-pushed
the
17038/pkger_export_check_tasks_bug
branch
from
486d084
to
754a8d5
Compare
jsteenb2
commented
Feb 28, 2020
cmd/influxd/launcher/pkger_test.go
Outdated
| @@ -408,52 +452,59 @@ spec: | |||
| assert.Equal(t, expected, secrets[0]) | |||
| }) | |||
|
|
|||
| t.Run("exporting all resources for an org", func(t *testing.T) { | |||
There was a problem hiding this comment.
massive gaping hole in test suite, totally missed this
wrong assumption in original design. The system tasks are actually the CRUD tasks. Name is a bit confusing for user generated tasks. closes: #17038
jsteenb2
force-pushed
the
17038/pkger_export_check_tasks_bug
branch
from
754a8d5
to
c590a25
Compare
imogenkinsman
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrong assumption in original design. The system tasks are actually
the CRUD tasks. Name is a bit confusing for user generated tasks.
closes: #17038