fix(ui): disabled group functionality for check query builder

[asalem1]

Closes #16956

Problem

Group functionality shouldn't exist on the query builder when setting up checks for alerts

Solution

Created custom logic to only display filter as an option and disable the dropdown to reduce functionality confusion

• CHANGELOG.md updated with a link to the PR (not the Issue)

[hoorayimhelping]

a seemingly small change - what is being passed to down, but the implications of where the logic of this change lives are big for the future

[hoorayimhelping]

Two comments on this block:

Generally: if you're going to do a statement of the form

if condition then foo
if !condition then bar

it's typically more common, and easier to follow an if/else

{options.length === 1 ? (<Dropdown />) : (<SelectDropdown />)}

the else is there to handle this specific case :)

Second: This method is inferring what state to put itself into based on, well an inference, rather than checking values or the state of the app.

The length of the options array being 1 may indicate that we should only show the filter, but it may also indicate something else. The issue here isn't hiding group when we're in the checks overlay, it's hiding group when the options list has one item in it - we may only want to show group, but the inference is that if there's only a single item, it must show filter.

What we're interested in is whether this is happening in the checks overlay, right? So how about passing isInCheckOverlay as a prop down to BuilderCardDropdownHeader - if the prop is present and true, only show filter, otherwise show group and filter.

I know it seems persnickety, but these small things add up in a codebase. I prefer this because it moves the logic into a single place, and it makes it clear, in context, what the intent is - you don't have to look through two files to see what's happening. It also concentrates the logic - rather than spreading the logic to be implicit in the length of the array, which is set based on whether we're in the check overlay, it instead renders a different control based on whether we're in the check overlay. It's like a 'one hop' logic resolution, versus a 'two hop' one with the options array.

[gueluelue]

Is the group functionality not intended for checks or is it just currently not implemented correctly and thus turned off via the UI?

[asalem1]

Hi @gueluelue thanks for the question. It's actually somewhere in between where the functionality was not intended for checks at the moment, and so it could not be implemented correctly for checks.