Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd/influx): add profile management #17170

Merged
merged 1 commit into from
Mar 12, 2020
Merged

feat(cmd/influx): add profile management #17170

merged 1 commit into from
Mar 12, 2020

Conversation

kelwang
Copy link
Contributor

@kelwang kelwang commented Mar 10, 2020 •
edited
Loading

Closes #15302

add multiple profiles feature as suggested in the ticket

add the ability to setup against another cluster, even if you have a profile file

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

demo
demo2

@kelwang kelwang force-pushed the cli_profiles branch 3 times, most recently from be975a1 to 7a43003 Compare March 10, 2020 18:44
@kelwang kelwang requested review from jsteenb2 and a team March 10, 2020 18:49
jsteenb2
jsteenb2 suggested changes Mar 10, 2020
View reviewed changes
profile.go Outdated Show resolved Hide resolved
http/backup_service.go Outdated Show resolved Hide resolved
jsteenb2
jsteenb2 reviewed Mar 10, 2020
View reviewed changes
cmd/influx/profile.go Outdated Show resolved Hide resolved
@kelwang kelwang requested a review from jsteenb2 March 10, 2020 19:41
@kelwang kelwang force-pushed the cli_profiles branch 2 times, most recently from ede7ca0 to 0591783 Compare March 10, 2020 20:03
jsteenb2
jsteenb2 reviewed Mar 10, 2020
View reviewed changes
cmd/influx/config.go Show resolved Hide resolved
cmd/influx/config/mock/config.go Outdated Show resolved Hide resolved
@sanderson sanderson mentioned this pull request Mar 10, 2020
Closed
jsteenb2
jsteenb2 suggested changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@jsteenb2 jsteenb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide mechanism for setup cmd to provide a name to the config that is created after setup api.

@kelwang kelwang force-pushed the cli_profiles branch 2 times, most recently from 84deb95 to f45bdf2 Compare March 11, 2020 15:48
@kelwang kelwang requested a review from jsteenb2 March 11, 2020 15:55
jsteenb2
jsteenb2 reviewed Mar 11, 2020
View reviewed changes
cmd/influx/setup.go Outdated Show resolved Hide resolved
jsteenb2
jsteenb2 reviewed Mar 11, 2020
View reviewed changes
cmd/influx/setup.go Outdated Show resolved Hide resolved
jsteenb2
jsteenb2 reviewed Mar 11, 2020
View reviewed changes
cmd/influx/setup.go Outdated Show resolved Hide resolved
jsteenb2
jsteenb2 suggested changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@jsteenb2 jsteenb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor things to touch up still

@kelwang kelwang force-pushed the cli_profiles branch 2 times, most recently from 17bd9d2 to b02e7be Compare March 11, 2020 16:35
@kelwang kelwang requested a review from jsteenb2 March 11, 2020 18:25
jsteenb2
jsteenb2 approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@jsteenb2 jsteenb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, testing local working well

@imogenkinsman
Copy link
Contributor

imogenkinsman commented Mar 11, 2020 •
edited
Loading

@kelwang could you drop a demo of this in channel before merging? I think it'd be valuable to get feedback on the CLI UX from the team. jk it's in another channel

@kelwang kelwang merged commit 2660c6e into master Mar 12, 2020
@kelwang kelwang deleted the cli_profiles branch March 12, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsteenb2 jsteenb2 jsteenb2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

influx cli support multiple profiles
3 participants
@kelwang @imogenkinsman @jsteenb2