fix(ui): remove gradients from logo svg components #17214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpaxton
requested review from
a team and
asalem1
and removed request for
a team
121watts
approved these changes
Mar 11, 2020
asalem1
suggested changes
Mar 11, 2020
| @@ -9,6 +9,7 @@ const GoLogo: SFC = () => { | |||
| height="100%" | |||
| xmlns="http://www.w3.org/2000/svg" | |||
| viewBox="0 0 300 300" | |||
| xmlSpace="preserve" | |||
There was a problem hiding this comment.
| .js9{fill:url(#SVGID_5_);} | ||
| .js10{fill:url(#SVGID_6_);} | ||
| .js5{fill:#699F63;} | ||
| .js6{fill:#699F63;} |
There was a problem hiding this comment.
Can we move these to a stylesheet?
There was a problem hiding this comment.
this matches the format of our other logo files. They are autogenerated, so i don't know how useful this would be.
There was a problem hiding this comment.
True, but we can also make things a little clearer if we wanted to. It's definitely not a deal breaker but something to keep in mind since we are doing it here:
| .js7{fill:#699F63;} | ||
| .js8{fill:#699F63;} | ||
| .js9{fill:#699F63;} | ||
| .js10{fill:#699F63;} | ||
| `} | ||
| </style> | ||
| <rect className="js0" width={300} height={300} /> |
There was a problem hiding this comment.
Can we rename these classes to be a bit more descriptive?
There was a problem hiding this comment.
this matches the format of our other logo files. They are autogenerated, so i don't know how useful this would be.
asalem1
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16906
<linearGradient>within an inline SVG does not work in Safari so long as a<base/>tag is present in the DOM (which it is)<base />tag we removed the gradients in favor of flat colorsHere is the working svgs in Safari