Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add dashboard empty state graphics #17297

Merged
merged 3 commits into from
Mar 16, 2020
Merged

feat(ui): add dashboard empty state graphics #17297

merged 3 commits into from
Mar 16, 2020

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Mar 16, 2020 •
edited
Loading

Closes #17150

  • Add empty state image assets for both light and dark modes
  • Implement graphics in empty state
  • Cleanup some old styles

Screen Shot 2020-03-16 at 3 15 46 PM
Screen Shot 2020-03-16 at 3 15 39 PM

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested review from a team and zoesteinkamp and removed request for a team March 16, 2020 22:22
zoesteinkamp
zoesteinkamp approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@zoesteinkamp zoesteinkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! excited to see this in prod!

@alexpaxton alexpaxton merged commit eb22677 into master Mar 16, 2020
@alexpaxton alexpaxton deleted the feat/dashboard-empty-graphic branch March 16, 2020 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoesteinkamp zoesteinkamp zoesteinkamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Graphic to Dashboard empty state
2 participants
@alexpaxton @zoesteinkamp