feat(pkger): extend tasks with ability to define and rename it #17353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelwang
reviewed
Mar 19, 2020
pkger/models.go
Outdated
| @@ -1897,6 +1898,13 @@ func (t *task) Labels() []*label { | |||
| } | |||
|
|
|||
| func (t *task) Name() string { | |||
| if displayName := t.displayName.String(); displayName != "" { | |||
There was a problem hiding this comment.
we should make an abstract struct for this. something like a basePkger
jsteenb2
force-pushed
the
17233/pkger_resource_uniq_by_name
branch
5 times, most recently
from
cb99c7f to
22ed9ea
Compare
jsteenb2
force-pushed
the
17233/pkger_resource_uniq_by_name
branch
from
22ed9ea to
b78ec52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #17233