Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd/influx): easy switch config #17472

Merged
merged 1 commit into from
Mar 27, 2020
Merged

feat(cmd/influx): easy switch config #17472

merged 1 commit into from
Mar 27, 2020

Conversation

kelwang
Copy link
Contributor

@kelwang kelwang commented Mar 27, 2020 •
edited
Loading

Closes #17401

Add an easy way to switch config, manually tested

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@kelwang kelwang force-pushed the simple_config_switch branch from 4590b92 to 57bdb22 Compare March 27, 2020 19:44
@kelwang kelwang requested review from a team and bthesorceror and removed request for a team March 27, 2020 19:44
@kelwang kelwang force-pushed the simple_config_switch branch from 57bdb22 to 5db57c9 Compare March 27, 2020 19:47
@kelwang kelwang requested a review from jsteenb2 March 27, 2020 19:48
jsteenb2
jsteenb2 approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@jsteenb2 jsteenb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. One nit, not related to this however, I wish we represented the Config with the name inside of it. Instead of having the map[name]config. Its a nit, but it concerns me having to juggle state in two places.... something to think about 🤷‍♂

@kelwang
Copy link
Contributor Author

kelwang commented Mar 27, 2020

looks good to me. One nit, not related to this however, I wish we represented the Config with the name inside of it. Instead of having the map[name]config. Its a nit, but it concerns me having to juggle state in two places.... something to think about 🤷‍♂

sure, will definitely think about it

@kelwang kelwang merged commit 51d3603 into master Mar 27, 2020
@kelwang kelwang deleted the simple_config_switch branch March 27, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsteenb2 jsteenb2 jsteenb2 approved these changes

@bthesorceror bthesorceror Awaiting requested review from bthesorceror

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shorten command to switch CLI config
2 participants
@kelwang @jsteenb2