Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): remove treenav flag #17581

Merged
merged 9 commits into from
Apr 7, 2020
Merged

feat(ui): remove treenav flag #17581

merged 9 commits into from
Apr 7, 2020

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Apr 2, 2020 •
edited
Loading

Closes #17579

  • Remove all instances of treeNav feature flag
  • Delete old nav components
    • Nav.tsx
    • AcountNavSubItems.tsx
    • CloudNav
  • Update settings page tabs
    • Remove members and about
  • Update router
    • Remove members, about, and profile from settings
    • Set variables to be the index route within settings
  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested review from a team and zoesteinkamp and removed request for a team April 2, 2020 17:40
zoesteinkamp
zoesteinkamp approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@zoesteinkamp zoesteinkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@alexpaxton alexpaxton merged commit 0677b88 into master Apr 7, 2020
@jacobmarble jacobmarble deleted the feat/remove-treenav-flag branch January 2, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoesteinkamp zoesteinkamp zoesteinkamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove treeNav Feature Flag
2 participants
@alexpaxton @zoesteinkamp