fix(ui): ensure all dashboard cards render the same size #17612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpaxton
requested review from
a team and
drdelambre
and removed request for
a team
asalem1
reviewed
Apr 3, 2020
| } | ||
| } | ||
|
|
||
| @media screen and (min-width: $cf-grid--breakpoint-md) { | ||
| .dashboards-card-grid { | ||
| grid-template-columns: 1fr 1fr 1fr; | ||
| grid-template-columns: minmax(33.3333%, 1fr) minmax(33.3333%, 1fr) minmax(33.3333%, 1fr); |
There was a problem hiding this comment.
minmax is like the CSS version of the interrobang
Also, fr???
There was a problem hiding this comment.
It's a CSS Grid thing. Stands for "fractional unit" and in this context controls how big the columns are. So 1fr 1fr 1fr means divide up into 3 even columns.
Using minmax() ensures that the columns don't exceed that size
asalem1
approved these changes
Apr 3, 2020
drdelambre
approved these changes
Apr 3, 2020
|
Fixed the failing e2e test and filed this issue in the process: influxdata/clockface#478 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16966
All cards are the same height regardless of contents or position
Cards with a long name don't change width and truncate the name