Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Querying for missing measurements should return a 200 #1813

Merged
merged 3 commits into from
Mar 3, 2015

Conversation

toddboom
Copy link
Contributor

@toddboom toddboom commented Mar 3, 2015

Currently, this returns a 500 Server Error. It should return a 200 OK with an error in the result set stating that the measurement name couldn't be found.

@toddboom toddboom changed the title Querying for missing measurements should return a 200 OK Querying for missing measurements should return a 200 Mar 2, 2015
@pauldix
Copy link
Member

pauldix commented Mar 2, 2015

This should also be true if the measurement doesn't have the field that the user is requesting. Basically, 500 responses should only be for actual server errors. And the only 400 response should be if the query didn't actually parse, or for unauthorized.

@toddboom toddboom self-assigned this Mar 2, 2015
@toddboom toddboom added this to the 0.9.0 milestone Mar 2, 2015
pauldix added a commit that referenced this pull request Mar 3, 2015
Querying for missing measurements should return a 200
@pauldix pauldix merged commit 97746c9 into master Mar 3, 2015
@inthecloud247
Copy link

@pauldix, any idea if this new functionality affects issue #1039 ?

@toddboom toddboom deleted the fix-1813-measurement-not-found branch May 4, 2015 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants