Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): expose bucketid #18319

Merged
merged 5 commits into from
Jun 4, 2020
Merged

feat(ui): expose bucketid #18319

merged 5 commits into from
Jun 4, 2020

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Jun 1, 2020 •
edited
Loading

Closes #18229

  • Display bucketid on user & demo data buckets
  • Clicking bucket id copies it to clipbboard (see attached gif)
  • Extracted bucket card meta and actions into separate components (makes BucketCard easier to read)

copy-bucket-id

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested review from a team and ebb-tide and removed request for a team June 1, 2020 18:22
@sanderson sanderson mentioned this pull request Jun 1, 2020
Closed
ebb-tide
ebb-tide suggested changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@ebb-tide ebb-tide left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! but i think the id will need to be added to the DemoDataBucketCard component for consistency?

@alexpaxton
Copy link
Contributor Author

@ebb-tide I did not think of that at all, glad I got you as a reviewer. Just pushed changes that add the "Copy ID" functionality to demo data bucket cards

ebb-tide
ebb-tide approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@ebb-tide ebb-tide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@alexpaxton alexpaxton merged commit 5dfeb0a into master Jun 4, 2020
@alexpaxton alexpaxton deleted the feat/expose-bucketid branch June 4, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebb-tide ebb-tide ebb-tide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it easier to determine bucket ID
2 participants
@alexpaxton @ebb-tide