-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UDP Listener #1848
Add UDP Listener #1848
Conversation
Issue: 1755 Bind the server to a UDP listener.
@@ -110,6 +111,17 @@ func Run(config *Config, join, version string, logWriter *os.File) (*messaging.B | |||
} | |||
} | |||
|
|||
// Start the server bound to a UDP listener | |||
if config.InputPlugins.UDPInput.Enabled { | |||
connectString := fmt.Sprintf("%s:%d", config.BindAddress, config.InputPlugins.UDPInput.Port) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a method on the config type.
Generally makes sense, though it needs testing. Sending UDP traffic back to the sender -- especially in the case of successful ingest -- seems like overkill to me. |
Since UDP, by nature, is unreliable, a client isn't going to do anything differently if it doesn't see those UDP packets come back. So I don't think there is any point sending UDP traffic back. Just log any errors and move on. |
@otoolep please take a look at the updated bits whenever you feel like it. |
Looks, +1 assuming you've actually seen data travel over UDP and been ingested by the system. An integration test should be next, but that can be a separate PR if you wish. |
When you do commit, don't forget to update the changelog. |
Since you know the PR (this one) you can make the change to the log as part of this change. |
Issue: 1755 Bind the server to a UDP listener to accept series data.
Issue: 1755
Bind the server to a UDP listener.