Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmdClick-task): Added command click functionality to tasks names to open in separate tab #18480

Merged
merged 3 commits into from
Jun 12, 2020

Conversation

asalem1
Copy link
Contributor

@asalem1 asalem1 commented Jun 12, 2020

Problem

Working with tasks requires a lot of back and forth

Solution

Integrate command+click functionality on task names so that users can open and browse multiple tasks in different tabs

command-click-task

  • CHANGELOG.md updated with a link to the PR (not the Issue)

Copy link
Contributor

@jsteenb2 jsteenb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👏

Copy link
Contributor

@drdelambre drdelambre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not make this a normal link?

@asalem1
Copy link
Contributor Author

asalem1 commented Jun 12, 2020

@drdelambre as in why not just remove the action and push to that location in general?

@asalem1 asalem1 requested a review from drdelambre June 12, 2020 16:18
Copy link
Contributor

@drdelambre drdelambre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QfxzI98-_400x400


### Features

1. [18480](https://github.com/influxdata/influxdb/pull/18480): Allows tasks to open in new tabs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think this is a feature, it's like, table stakes of a browser.

if it has to be in the changelog, i think it should go under ### UI Enhancements

@asalem1 asalem1 merged commit daad4b5 into master Jun 12, 2020
@asalem1 asalem1 deleted the feat/task-separate-page branch June 12, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants