Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: uint overflow during setup on 32bit systems #18602

Merged
merged 1 commit into from
Jun 18, 2020
Merged

fix: uint overflow during setup on 32bit systems #18602

merged 1 commit into from
Jun 18, 2020

Conversation

mhall119
Copy link
Contributor

@mhall119 mhall119 commented Jun 18, 2020 •
edited
Loading

Convert onboardingRequest RetentionPeriod to a Duration, rather than time.Hour to a uint.

Closes #18547

Describe your proposed changes here.

@mhall119 mhall119 changed the title Fix uint overflow during setup on 32bit systems fix: uint overflow during setup on 32bit systems Jun 18, 2020
@mhall119 mhall119 force-pushed the master branch 2 times, most recently from 1f470f4 to 02d6684 Compare June 18, 2020 16:23
@mhall119 mhall119 requested a review from jsteenb2 June 18, 2020 16:37
jsteenb2
jsteenb2 approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@jsteenb2 jsteenb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhall119 mhall119 merged commit f8d44d7 into influxdata:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsteenb2 jsteenb2 jsteenb2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Constant UINT declaration causing GO Compiler to fail on x86
2 participants
@mhall119 @jsteenb2