Support control of Raft debug logging #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
raft_log_trace
branch
2 times, most recently
from
44cab9e
to
b4d9396
Compare
| @@ -98,6 +98,7 @@ type Config struct { | |||
| Logging struct { | |||
| File string `toml:"file"` | |||
| WriteTraceEnabled bool `toml:"write-tracing"` | |||
| RaftTraceEnabled bool `toml:"raft-tracing"` | |||
There was a problem hiding this comment.
Should just remove Enabled from these. Otherwise everything in this struct is going to have that after it. Besides, this looks fine:
if log.WriteTrace {
// do stuff
}
|
Updated. |
|
|
otoolep
added a commit
that referenced
this pull request
Mar 9, 2015
Support control of Raft debug logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.