feat(pkger): make stacks event sourced #18888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
force-pushed
the
18874/stacks_event_sourced
branch
from
031ba6f
to
9daff71
Compare
bthesorceror
approved these changes
Jul 8, 2020
jsteenb2
force-pushed
the
18874/stacks_event_sourced
branch
from
9daff71
to
a1a4b19
Compare
jsteenb2
force-pushed
the
18874/stacks_event_sourced
branch
from
a1a4b19
to
6877eaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is a bit of a monster. It upends all the stacks to be event sourced (sorta). The idea is this. We track each change to a stack, create/update/delete. When we retrieve the stack, it has all the details for that stack's operations.
Things that are painful... working with a kv store here. Having a relational store here would have been super nice. We can order stacks listed coherently without having to force the app layer to get into the kv store weeds. Will take this as a follow up action item to see if I can make this a forcing function for using a relational store. Boy would that make this a thing of beauty.
closes: #18874