Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable protected names #18921

Merged
merged 4 commits into from
Jul 10, 2020
Merged

Variable protected names #18921

merged 4 commits into from
Jul 10, 2020

Conversation

zoesteinkamp
Copy link
Contributor

Closes #17457
Screen Shot 2020-07-10 at 10 45 42 AM

Describe your proposed changes here.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

glinton
glinton approved these changes Jul 10, 2020
View reviewed changes
variable.go Outdated Show resolved Hide resolved
variable.go Outdated Show resolved Hide resolved
variable.go Outdated Show resolved Hide resolved
@zoesteinkamp zoesteinkamp merged commit e8aeba4 into master Jul 10, 2020
@zoesteinkamp zoesteinkamp deleted the variableprotectednames branch July 10, 2020 21:46
@sanderson sanderson mentioned this pull request Jul 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glinton glinton glinton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent creating variables that are flux keywords
2 participants
@zoesteinkamp @glinton