Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make Single Stat cells work in Safari again #18969

Merged
merged 2 commits into from
Jul 16, 2020
Merged

fix: make Single Stat cells work in Safari again #18969

merged 2 commits into from
Jul 16, 2020

Conversation

hoorayimhelping
Copy link
Contributor

@hoorayimhelping hoorayimhelping commented Jul 15, 2020 •
edited
Loading

Closes #18964
Closes #18966

Explicitly set the display to flex.

#18964

Safari
Screen Shot 2020-07-15 at 4 46 59 PM

Firefox
Screen Shot 2020-07-15 at 4 47 09 PM

Chrome
Screen Shot 2020-07-15 at 4 51 34 PM

#18964

Screen Shot 2020-07-15 at 4 52 02 PM

@hoorayimhelping hoorayimhelping changed the title Bucky fix safari single stat fix: make Single Stat cells work in Safari again Jul 15, 2020
@hoorayimhelping hoorayimhelping requested review from a team, ebb-tide, drdelambre and TCL735 and removed request for a team and drdelambre July 15, 2020 23:57
121watts
121watts approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@121watts 121watts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! one line can make all the difference.

@hoorayimhelping hoorayimhelping merged commit 52e7b3c into master Jul 16, 2020
@jacobmarble jacobmarble deleted the bucky_fix_safari_single_stat branch January 2, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@121watts 121watts 121watts approved these changes

@ebb-tide ebb-tide Awaiting requested review from ebb-tide

@TCL735 TCL735 Awaiting requested review from TCL735

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hoorayimhelping @121watts