Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update limit and offset #1900

Merged
merged 3 commits into from
Mar 10, 2015
Merged

Update limit and offset #1900

merged 3 commits into from
Mar 10, 2015

Conversation

pauldix
Copy link
Member

@pauldix pauldix commented Mar 10, 2015

This PR changes LIMIT and OFFSET to SLIMIT and SOFFSET. It also implements LIMIT and OFFSET to limit the number of data points returned per series in the result.

@toddboom
Copy link
Contributor

This looks good. My only two questions are:

  1. Should we use SLimit and SOffset instead of Slimit and Soffset for clarity?
  2. Should the changes in server_test.go actually be duplicated/expanded so that we're testing both LIMIT/OFFSET and SLIMIT/SOFFSET?

@pauldix
Copy link
Member Author

pauldix commented Mar 10, 2015

@toddboom: The tests for LIMIT and OFFSET are in server_integration_test.go, which is where these other ones should go eventually. I just didn't want to bother transferring them over in this PR.

Once the race condition stuff gets resolved so that writes don't have to wait 3 seconds in those integration tests, I'll get more aggressive about moving more of the tests in there.

Updated Slimit and Soffset to SLimit and SOffset in the code.

@toddboom
Copy link
Contributor

rad, 👍!

toddboom added a commit that referenced this pull request Mar 10, 2015
Update LIMIT/OFFSET and SLIMIT/SOFFSET
@toddboom toddboom merged commit 031ea1d into master Mar 10, 2015
@toddboom toddboom deleted the update-limit-and-offset branch March 10, 2015 03:14
@duylong
Copy link

duylong commented Mar 10, 2015

Good feature +1

Could we not set a default limit ? (for example defined in the configuration file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants