-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: X axis not accepting value & Y axis only accepting value #19044
Conversation
The fix for the x axis
The fix + start of unit test
adding the tests
Fixing the merge conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks solid. i would add unit tests for the reducer also.
We did try to add the unit test for the reducer, but we need to get the mocking done first, so that going to be addressed at a later date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once you fix up the description, it LGTM
cy.getByTestID('dropdown-y').click() | ||
cy.getByTitle('_time').click() | ||
cy.getByTestID('dropdown-y').contains('_time') | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! is it possible to assert that clicking it does something? maybe something we can add when we pair up on unit tests
Closes #18884
These changes will fix the X axis so they will accept _value. It will fix the Y axis so it will accept values other than _values. There are end to end test testing that both the X and the Y can select all values including time, start, stop, and value.