Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: X axis not accepting value & Y axis only accepting value #19044

Merged
merged 6 commits into from
Jul 23, 2020

Conversation

zoesteinkamp
Copy link
Contributor

@zoesteinkamp zoesteinkamp commented Jul 23, 2020

Closes #18884

These changes will fix the X axis so they will accept _value. It will fix the Y axis so it will accept values other than _values. There are end to end test testing that both the X and the Y can select all values including time, start, stop, and value.

Copy link
Contributor

@121watts 121watts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks solid. i would add unit tests for the reducer also.

@zoesteinkamp
Copy link
Contributor Author

zoesteinkamp commented Jul 23, 2020

this looks solid. i would add unit tests for the reducer also.

We did try to add the unit test for the reducer, but we need to get the mocking done first, so that going to be addressed at a later date

Copy link
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once you fix up the description, it LGTM

cy.getByTestID('dropdown-y').click()
cy.getByTitle('_time').click()
cy.getByTestID('dropdown-y').contains('_time')
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! is it possible to assert that clicking it does something? maybe something we can add when we pair up on unit tests

@hoorayimhelping
Copy link
Contributor

good call @121watts. we actually discussed it and looked into it and realized we'd have to do some work that might take a little while and hold this up, so we wrote it up in a ticket #19046 and are going to talk about it tomorrow when we pair up 👍

@zoesteinkamp zoesteinkamp changed the title X axis not accepting value, and Y axis only accepting value fix: X axis not accepting value & Y axis only accepting value Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot change the x-axis for line graph
3 participants